ebyhr commented on code in PR #15907: URL: https://github.com/apache/iceberg/pull/15907#discussion_r3048652849
########## flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java: ########## Review Comment: nit: The `checkArgument` method supports a string template, so there's no need to use `String.format` on the caller side: ```java checkArgument(boolean expression, String errorMessageTemplate, @Nullable Object... errorMessageArgs) ``` Please feel free to ignore this comment since it's unrelated to the error message change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
