mxm commented on code in PR #15907:
URL: https://github.com/apache/iceberg/pull/15907#discussion_r3060972050
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java:
##########
@@ -147,12 +147,11 @@ void validate() {
"Invalid starting snapshot timestamp for
SPECIFIC_START_SNAPSHOT_TIMESTAMP strategy: null");
Preconditions.checkArgument(
startSnapshotId == null,
- "Invalid starting snapshot id for SPECIFIC_START_SNAPSHOT_ID
strategy: not null");
+ "Invalid starting snapshot id for
SPECIFIC_START_SNAPSHOT_TIMESTAMP strategy: not null");
Review Comment:
```suggestion
"Invalid starting snapshot id for %s strategy: not null",
startingStrategy);
```
Let's interpolate the string to prevent copy/paste issues in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
