stevenzwu commented on code in PR #15895: URL: https://github.com/apache/iceberg/pull/15895#discussion_r3049387330
########## api/src/main/java/org/apache/iceberg/catalog/SupportsReferencedBy.java: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.catalog; + +import java.util.List; +import org.apache.iceberg.Table; +import org.apache.iceberg.view.View; + +/** Catalog methods for loading tables and views with a referenced-by view chain. */ +public interface SupportsReferencedBy { Review Comment: We have been using `TableIdentifier` for views probably because we don't want to introduce a `ViewIdentifier` exactly same as `TableIdentifier`. I would hope that we can align on one generic `CatalogObjectIdentifier` for all new REST spec and Java implementations. https://docs.google.com/document/d/1NTQhgNbP2dkIMuXUMA5JdwliVQKCp1TU_ux5J_AaPiw/edit?tab=t.0#heading=h.lrmay9r6i8ai We probably don't need a specific view identifier in the REST spec. My initial comment is if we need to support `referenced-by` for the relations endpoint. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
