singhpk234 commented on code in PR #15895: URL: https://github.com/apache/iceberg/pull/15895#discussion_r3070377415
########## api/src/main/java/org/apache/iceberg/catalog/SupportsReferencedBy.java: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.catalog; + +import java.util.List; +import org.apache.iceberg.Table; +import org.apache.iceberg.view.View; + +/** Catalog methods for loading tables and views with a referenced-by view chain. */ +public interface SupportsReferencedBy { Review Comment: > My initial comment is if we need to support referenced-by for the relations endpoint. TableIdentifier is the universal identifier for views today — happy to adopt a generic type when it lands and yes i agree we would require to send the reference-by to the relations endpoint as well :) > who is this interface for Its instanceof discovery pattern used by SparkCatalog as the underlying icebergCatalog that sparkCatalog holds would be implementing it like RESTCatalog [[1](https://github.com/apache/iceberg/pull/13979/changes#diff-18cb3985841ead0d8bc4c6e712fe4216d548f8904c2f65fa15f55d01ad9a8c47R912)], i plan to make RESTCatalog implement SupportsReferencedBy interface [[2](https://github.com/apache/iceberg/pull/13979/changes#diff-bcb50214ee48255c5b289ef1b64ac3c835a4b6a5dd76afaf7e887f2efb0e10fdR51)] Please let me know wdyt please ref E2E impl i have in mind : https://github.com/apache/iceberg/pull/13979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
