alliasgher opened a new pull request, #878: URL: https://github.com/apache/iceberg-go/pull/878
## Summary `GetWriteProperties` read compression, page size, row group size etc. but silently ignored the two bloom filter properties defined in the same file: - `write.parquet.bloom-filter-max-bytes` — caps the per-column bloom filter size (default 1 MB) - `write.parquet.bloom-filter-enabled.column.<name>` — enables bloom filters per column Wire them through to the Arrow Parquet writer: - `WithMaxBloomFilterBytes` is always applied (defaults to the existing `ParquetBloomFilterMaxBytesDefault` constant). - All table properties whose key starts with `write.parquet.bloom-filter-enabled.column.` are scanned; for each match `WithBloomFilterEnabledFor` is called with the column name and parsed boolean. Fixes #844 ## Test plan - [x] `go test ./...` - [x] `gofmt` clean - [x] New `TestGetWritePropertiesBloomFilter` covering default max-bytes, custom max-bytes, and per-column enable/disable. Signed-off-by: Ali <[email protected]> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
