hcrosse commented on code in PR #15700:
URL: https://github.com/apache/iceberg/pull/15700#discussion_r3089102423
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -706,6 +709,29 @@ private static CompressionCodecName toCodec(String
codecAsString) {
}
}
+ private static String fromWriterVersion(WriterVersion writerVersion) {
+ switch (writerVersion) {
+ case PARQUET_1_0:
+ return "1";
+ case PARQUET_2_0:
+ return "2";
+ default:
+ throw new IllegalArgumentException("Unsupported writer version: "
+ writerVersion);
+ }
+ }
Review Comment:
Good call, made both changes!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
