mxm commented on code in PR #15700:
URL: https://github.com/apache/iceberg/pull/15700#discussion_r3080682525
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -266,6 +268,7 @@ public WriteBuilder overwrite(boolean enabled) {
}
public WriteBuilder writerVersion(WriterVersion version) {
+ Preconditions.checkNotNull(version, "Writer version cannot be null");
this.writerVersion = version;
Review Comment:
How about:
```suggestion
this.config.put(TableProperties.PARQUET_PAGE_VERSION, version.name());
```
The advantage would be that we use a single source of truth and can remove
the `writerVersion` field from the builder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
