vladislav-sidorovich commented on code in PR #15991:
URL: https://github.com/apache/iceberg/pull/15991#discussion_r3107107805
##########
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryProperties.java:
##########
@@ -101,11 +101,37 @@ List<String> expandScopes(List<String> inputScopes) {
BigQueryProperties(Map<String, String> properties) {
Preconditions.checkNotNull(properties, "Properties cannot be null");
- this.projectId = properties.get(PROJECT_ID);
+ Preconditions.checkArgument(
+ !(properties.containsKey(PROJECT_ID)
+ && properties.containsKey(HistoricalPropertyNames.PROJECT_ID)),
+ "Invalid GCP project configuration. "
+ + "Found both properties '%s' and '%s', only one must be used.",
+ PROJECT_ID,
+ HistoricalPropertyNames.PROJECT_ID);
Review Comment:
I suggest to `promote` only OSS version of properties. So, let's remove
`HistoricalPropertyNames.PROJECT_ID` from the error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
