vladislav-sidorovich commented on PR #15991: URL: https://github.com/apache/iceberg/pull/15991#issuecomment-4276308168
> Hi @dbjnbnrj , Thank you for submitting the PR! > > I'm pretty hesitant to add something to OSS Iceberg that is to cover some proprietary internal mechanism TBH. As you write in `HistoricalPropertyNames` these params are to fallback to some Google internal stuff, I don't see much benefit of adding these to open source. Let's see what others think. The benefit here is to provide the ability to Iceberg users to use OSS Iceberg libraries in GCP without migrating their existing payload. I agree that proprietary internal details must be avoid in OSS solutions. The intention here is to increase usage of OSS Iceberg version. The trade-off is support of 2 properties vs seamless migration to Iceberg OSS version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
