pvary commented on code in PR #16011:
URL: https://github.com/apache/iceberg/pull/16011#discussion_r3110403395
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicWriteResultAggregator.java:
##########
@@ -105,8 +141,8 @@ public void prepareSnapshotPreBarrier(long checkpointId)
throws IOException {
new DynamicCommittable(
entries.getKey(),
writeToManifests(entries.getKey().tableName(),
entries.getValue(), checkpointId),
- getContainingTask().getEnvironment().getJobID().toString(),
- getRuntimeContext().getOperatorUniqueID(),
+ flinkJobId,
Review Comment:
How did we handle this in the old sink? Would it be confusing if the jobId
is not changing with the job?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
