lrsb commented on code in PR #16011:
URL: https://github.com/apache/iceberg/pull/16011#discussion_r3117513881
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicWriteResultAggregator.java:
##########
@@ -128,8 +159,8 @@ public void prepareSnapshotPreBarrier(long checkpointId)
throws IOException {
new DynamicCommittable(
entries.getKey(),
writeToManifests(entries.getKey().tableName(),
entries.getValue(), checkpointId),
- getContainingTask().getEnvironment().getJobID().toString(),
- getRuntimeContext().getOperatorUniqueID(),
+ flinkJobId,
+ operatorId,
checkpointId),
Review Comment:
Regarding the job id change during rescalings, that happens when the scaling
is applied using stop with savepoint and then the parallelism is overridden at
vertex level, without involving the stock Flink autoscaler. I agree this is not
the standard setup but might be a possibility when the autoscaler cannot be
used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
