nastra commented on code in PR #15312:
URL: https://github.com/apache/iceberg/pull/15312#discussion_r3115765107
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3OutputStream.java:
##########
@@ -112,14 +109,8 @@ class S3OutputStream extends PositionOutputStream {
synchronized (S3OutputStream.class) {
if (executorService == null) {
executorService =
- MoreExecutors.getExitingExecutorService(
- (ThreadPoolExecutor)
- Executors.newFixedThreadPool(
- s3FileIOProperties.multipartUploadThreads(),
- new ThreadFactoryBuilder()
- .setDaemon(true)
- .setNameFormat("iceberg-s3fileio-upload-%d")
- .build()));
+ ThreadPools.newExitingWorkerPool(
Review Comment:
why are we updating only this place and not other places as well? Not saying
that we should update all places in this PR but I'm trying to understand why
only this file is updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
