nastra commented on code in PR #15312:
URL: https://github.com/apache/iceberg/pull/15312#discussion_r3115849947
##########
core/src/main/java/org/apache/iceberg/util/ThreadPools.java:
##########
@@ -149,8 +153,89 @@ public static ExecutorService newWorkerPool(String
namePrefix, int poolSize) {
* that should be automatically cleaned up on JVM shutdown.
*/
public static ExecutorService newExitingWorkerPool(String namePrefix, int
poolSize) {
- return MoreExecutors.getExitingExecutorService(
- (ThreadPoolExecutor) newFixedThreadPool(namePrefix, poolSize));
+ ExecutorService service =
+ Executors.unconfigurableExecutorService(newFixedThreadPool(namePrefix,
poolSize));
+ THREAD_POOL_MANAGER.addThreadPool(service, DEFAULT_SHUTDOWN_TIMEOUT);
+ return service;
+ }
+
+ /**
+ * Shuts down all thread pools registered via {@link
#newExitingWorkerPool(String, int)} or {@link
+ * #newExitingScheduledPool(String, int, Duration)} and removes the JVM
shutdown hook.
+ *
+ * <p>This method is useful for:
+ *
+ * <ul>
+ * <li>Preventing thread pool leaks in hot-reload environments
+ * <li>Managing graceful application shutdown when the application needs
to handle its own
+ * shutdown hooks (e.g. to commit pending files before exiting)
+ * </ul>
+ *
+ * <p>Only call this method at the end of the intended usage of the library.
Calling it earlier
Review Comment:
I think we should use some other wording than `library`. Also we should be
more explicit about when this should be used, because calling this at the wrong
time will cause unwanted side effects and errors that are hard to debug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
