swapna267 commented on code in PR #15780:
URL: https://github.com/apache/iceberg/pull/15780#discussion_r3120947862
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicRecord.java:
##########
@@ -38,6 +40,7 @@ public class DynamicRecord {
private int writeParallelism;
private boolean upsertMode;
@Nullable private Set<String> equalityFields;
+ @Nullable private FlinkWriteConf flinkWriteConf;
Review Comment:
Thanks @pvary and @mxm for the suggestions. Sounds good, we can go with the
wrapper. I will add a comment for now on DynamicRecord to ensure Wrapper
overrides new methods in future.
Thanks for pointing out reusing of DynamicRecord. Makes sense.
Think it's better if we show that pattern
https://iceberg.apache.org/docs/nightly/flink-writes/#flink-dynamic-iceberg-sink
here in docs, so users are clear on thread safety.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
