swapna267 commented on code in PR #15780:
URL: https://github.com/apache/iceberg/pull/15780#discussion_r3112358990
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicRecord.java:
##########
@@ -38,6 +40,7 @@ public class DynamicRecord {
private int writeParallelism;
private boolean upsertMode;
@Nullable private Set<String> equalityFields;
+ @Nullable private FlinkWriteConf flinkWriteConf;
Review Comment:
Don't see issues with backward compatibility If we leave the
`DynamicRecordGenerator` to continue using `generate(T inputRecord,
Collector<DynamicRecord> out)`
But do we want to expose interface change to users ? If end users also have
similar use case of wrapping any other object in upstream operator, it may be
useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
