nssalian commented on code in PR #932:
URL: https://github.com/apache/iceberg-go/pull/932#discussion_r3126608147
##########
types.go:
##########
@@ -777,6 +779,20 @@ func (UnknownType) primitive() {}
func (UnknownType) Type() string { return "unknown" }
func (UnknownType) String() string { return "unknown" }
+// VariantType represents semi-structured data stored using the Parquet Variant
+// binary encoding. Requires format version 3+.
+type VariantType struct{}
+
+func (VariantType) Equals(other Type) bool {
+ _, ok := other.(VariantType)
+
+ return ok
+}
+
+func (VariantType) primitive() {}
Review Comment:
Agreed. I modeled it as PrimitiveType for convenience with the visitor but
I'll rework this. It might need its own category in `visitField`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
