nssalian commented on PR #932: URL: https://github.com/apache/iceberg-go/pull/932#issuecomment-4362613722
Addressed all comments. Variant is no longer PrimitiveType. I added Variant() on all visitor interfaces. Replaced []byte with dedicated boundVariantRef/boundVariantUnaryPred. Split the validator so variant can be required per spec. colMapping skip now checks parent is actually a variant field. Extracted projectVariant. Added tests for unary predicates, nested types (struct/list/map), multi-variant schemas, and projection exclusion. I tested with Spark 4.x locally and it gave the same results as in the PR description. I'll follow up with a PR to add Spark 4 support in the Integration tests and have this integration test updated to match the others. @zeroshade @laskoviymishka PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
