svalaskevicius commented on code in PR #15312:
URL: https://github.com/apache/iceberg/pull/15312#discussion_r3136904860
##########
core/src/main/java/org/apache/iceberg/util/ThreadPools.java:
##########
@@ -123,12 +132,7 @@ public static ExecutorService newWorkerPool(String
namePrefix) {
}
/**
- * Creates a fixed-size thread pool that uses daemon threads. The pool is
wrapped with {@link
- * MoreExecutors#getExitingExecutorService(ThreadPoolExecutor)}, which
registers a shutdown hook
- * to ensure the pool terminates when the JVM exits. <b>Important:</b> Even
if the pool is
- * explicitly shut down using {@link ExecutorService#shutdown()}, the
shutdown hook is <i>not</i>
- * removed. This can lead to accumulation of shutdown hooks if this method
is used repeatedly for
- * short-lived thread pools.
+ * Creates a fixed-size thread pool that uses daemon threads.
Review Comment:
actually it's right there:
> The pool will be stopped by the
> * shutdown hook to ensure the pool terminates when the JVM exits -
unless `removeShutdownHook` is
> * called, in which case it is user's responsibility to stop the
threadpools using the
> * `shutdownThreadPools` method.
or do you have something else in mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
