mizoz opened a new pull request, #950:
URL: https://github.com/apache/iceberg-go/pull/950

   Fixes #941.
   
   ## Summary
   
   - Remove `s3.connect-timeout` from the unsupported S3 property path.
   - Parse `s3.connect-timeout` as a Go duration and apply it to the AWS SDK 
buildable client's dialer timeout.
   - Preserve existing proxy support by sharing the same buildable HTTP client 
when both proxy and connect timeout are configured.
   - Add focused tests for valid and invalid connect timeout values.
   
   ## Testing
   
   - `go test ./io/gocloud`
   - `git diff --check && go test ./...`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to