rchowell commented on code in PR #2380:
URL: https://github.com/apache/iceberg-rust/pull/2380#discussion_r3161806194
##########
crates/catalog/sql/src/catalog.rs:
##########
@@ -297,6 +297,24 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)?;
+ // Check if the catalog table has the iceberg_type column, if not,
it's a V0 schema.
+ let needs_migration = sqlx::query(&format!(
Review Comment:
I agree, however this is the same behavior as iceberg-java which by default
does auto-migration.
https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java#L157
I am happy to change this if you still believe iceberg-rust should have a
different behavior. Any thoughts on the config name since it does not exist in
other libs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
