aihuaxu commented on PR #14297: URL: https://github.com/apache/iceberg/pull/14297#issuecomment-4348071840
> @pvary @aihuaxu @huaxingao PTAL. Latest additions: I added a DecimalPrimitiveWriter to handle decimal scale and precision values at write time to make sure it works well. Added a couple of tests too. I'm hoping to get this initial PR merged and follow up with any additional changes. It's already large enough and I'm prefer not to add more scope to this beyond wiring the shredding logic. The change looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
