nssalian commented on PR #14297: URL: https://github.com/apache/iceberg/pull/14297#issuecomment-4354613631
Thanks for the reviews @steveloughran @qlong - all great points. I'd like to land this PR as-is and I can follow up with a PR to address these since the PR is already large. I summarized here: - Configurable shredding parameters for workload tuning - TreeMap to HashMap optimization in PathNode, sort once at schema build time - TIE_BREAK_PRIORITY javadoc + reorder STRING above BINARY - Debug logging in buildShreddedAppender - Switch statement in ParquetFormatModel.set() - Docs: qualify query performance claim None of these affect correctness. Happy to open the follow-up immediately after merge if there is agreement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
