pan3793 commented on code in PR #16155:
URL: https://github.com/apache/iceberg/pull/16155#discussion_r3166423892
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergStreamWriterMetrics.java:
##########
@@ -51,18 +63,12 @@ public IcebergStreamWriterMetrics(MetricGroup metrics,
String fullTableName) {
this.lastFlushDurationMs = new AtomicLong();
writerMetrics.gauge("lastFlushDurationMs", lastFlushDurationMs::get);
- com.codahale.metrics.Histogram dropwizardDataFilesSizeHistogram =
- new com.codahale.metrics.Histogram(new
SlidingWindowReservoir(HISTOGRAM_RESERVOIR_SIZE));
this.dataFilesSizeHistogram =
- writerMetrics.histogram(
- "dataFilesSizeHistogram",
- new DropwizardHistogramWrapper(dropwizardDataFilesSizeHistogram));
Review Comment:
I might miss something - just wonder why Flink's built-in
`DescriptiveStatisticsHistogram` does not work here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
