rdblue commented on code in PR #16155:
URL: https://github.com/apache/iceberg/pull/16155#discussion_r3171094452
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergStreamWriterMetrics.java:
##########
@@ -43,6 +50,11 @@ public class IcebergStreamWriterMetrics {
private final Histogram deleteFilesSizeHistogram;
public IcebergStreamWriterMetrics(MetricGroup metrics, String fullTableName)
{
+ this(metrics, fullTableName,
IcebergStreamWriterMetrics.class.getClassLoader());
+ }
+
+ @VisibleForTesting
+ IcebergStreamWriterMetrics(MetricGroup metrics, String fullTableName,
ClassLoader classLoader) {
Review Comment:
Is there a use case for passing a different `ClassLoader`? I thought that
whatever loader was used here made the most sense because applications could be
jailed to a app-specific loader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
