stevenzwu commented on code in PR #16107:
URL: https://github.com/apache/iceberg/pull/16107#discussion_r3169808211
##########
gcp-bundle/build.gradle:
##########
@@ -23,18 +23,13 @@ project(":iceberg-gcp-bundle") {
tasks.jar.dependsOn tasks.shadowJar
- configurations {
- implementation {
- exclude group: 'com.google.code.findbugs', module: 'jsr305'
- }
- }
-
dependencies {
implementation platform(libs.google.libraries.bom)
implementation "com.google.cloud:google-cloud-storage"
implementation "com.google.cloud:google-cloud-bigquery"
implementation "com.google.cloud:google-cloud-core"
implementation "com.google.cloud:google-cloud-kms"
+ implementation "com.google.cloud:google-cloud-monitoring"
Review Comment:
we should be very careful with dependency change for runtime bundle jar. was
this PR created after all the dependency/license fixes. at least, rebase with
the latest main branch. CI should catch dependency/license problems nowadays.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
