danielcweeks commented on code in PR #15630: URL: https://github.com/apache/iceberg/pull/15630#discussion_r3174519925
########## format/spec.md: ########## @@ -123,9 +128,22 @@ Tables do not require random-access writes. Once written, data and metadata file Tables do not require rename, except for tables that use atomic rename to implement the commit operation for new metadata files. +### File Locations in Metadata + +Version 4 of the Iceberg spec adds support for relative locations in metadata, enabling tables to be relocated without rewriting metadata files. Key changes include: Review Comment: This is going to get a little pedantic, but I think that's fair to include. The issue is that there is disagreement about what 'absolute' and 'fully-qualified' actually mean. In many contexts, they're considered equivalent. However, in other contexts, 'absolute' would not require a scheme, while 'fully-qualified' does require a scheme. Though, at the same time, 'fully-qualified' also allows for relative references. I think we want to define 'absolute' as requiring a scheme without relative or special references (as we have done here). That allows to at least make the argument that 'fully-qualified' is what the spec previously expected (though only explicitly called out for the `referenced_data_file` field). We were not explicit in the spec about the contents of other fields. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
