rambleraptor commented on code in PR #3285:
URL: https://github.com/apache/iceberg-python/pull/3285#discussion_r3175569624
##########
pyiceberg/table/delete_file_index.py:
##########
@@ -103,45 +147,75 @@ def _partition_key(spec_id: int, partition: Record |
None) -> tuple[int, Record]
class DeleteFileIndex:
- """Indexes position delete files by partition and by exact data file
path."""
+ """Indexes position and equality delete files by partition and by exact
data file path."""
- def __init__(self) -> None:
+ def __init__(self, schema: Schema | None = None) -> None:
+ self._schema = schema
self._by_partition: dict[tuple[int, Record], PositionDeletes] = {}
self._by_path: dict[str, PositionDeletes] = {}
+ self._eq_by_partition: dict[tuple[int, Record], EqualityDeletes] = {}
Review Comment:
Yep, good thinking. Made that fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]