rambleraptor commented on code in PR #3285: URL: https://github.com/apache/iceberg-python/pull/3285#discussion_r3175574385
########## pyiceberg/io/pyarrow.py: ########## @@ -1693,7 +1693,12 @@ def _task_to_record_batches( def _read_all_delete_files(io: FileIO, tasks: Iterable[FileScanTask]) -> dict[str, list[ChunkedArray]]: Review Comment: Yeah, we'll see some crashes if we don't have this here. Later on (in `to_record_batches` I believe), we try to grab invalid fields on them (since that part of the codebase doesn't expect Equality Deletes). That feels more natural to be part of the follow-up for handling FileScanTasks. In the mean time, we'll filter them out here to avoid a crash. Doesn't impact how the indexes work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
