ebyhr commented on code in PR #3290:
URL: https://github.com/apache/iceberg-python/pull/3290#discussion_r3179022456
##########
pyiceberg/catalog/dynamodb.py:
##########
@@ -210,12 +210,13 @@ def create_table(
return self.load_table(identifier=identifier)
- def register_table(self, identifier: str | Identifier, metadata_location:
str) -> Table:
+ def register_table(self, identifier: str | Identifier, metadata_location:
str, overwrite: bool = False) -> Table:
"""Register a new table using existing metadata.
Args:
identifier (Union[str, Identifier]): Table identifier for the table
metadata_location (str): The location to the metadata
+ overwrite (bool): Whether to overwrite the existing table, default
False
Review Comment:
This method in dynamodb and noop always raises `NotImplementedError`. Do we
still need a separate logc for the `overwrite` argument?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
