Fokko commented on PR #3290: URL: https://github.com/apache/iceberg-python/pull/3290#issuecomment-4369412037
> Looks good to me, one small nit would be to add some tests in integration tests [here](https://github.com/apache/iceberg-python/blob/main/tests/integration/test_catalog.py#L585) if the iceberg rest image supports the overwriting flag Right now we're locked at an older version of the Image: https://github.com/apache/iceberg-python/pull/3240/. Once there is a new Java release, we can definitly add this test. > any chance for this to get merged, currently, i am doing tuncate and add files with other tool, and it is a pain as it is not atomic @djouallah Since everybody approved, I went ahead and merged this 👍 Thanks @ebyhr for working on this, and thanks @ndrluis and @kevinjqliu for the review 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
