kamcheungting-db commented on code in PR #589: URL: https://github.com/apache/iceberg-cpp/pull/589#discussion_r3179588528
########## src/iceberg/catalog/memory/in_memory_catalog.h: ########## @@ -105,6 +106,7 @@ class ICEBERG_EXPORT InMemoryCatalog std::shared_ptr<FileIO> file_io_; std::string warehouse_location_; std::unique_ptr<class InMemoryNamespace> root_namespace_; + std::shared_ptr<MetricsReporter> reporter_; Review Comment: please add comment abort this new member ########## src/iceberg/catalog/memory/in_memory_catalog.h: ########## @@ -105,6 +106,7 @@ class ICEBERG_EXPORT InMemoryCatalog std::shared_ptr<FileIO> file_io_; std::string warehouse_location_; std::unique_ptr<class InMemoryNamespace> root_namespace_; + std::shared_ptr<MetricsReporter> reporter_; Review Comment: please add comment about this new member -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
