kamcheungting-db commented on code in PR #589:
URL: https://github.com/apache/iceberg-cpp/pull/589#discussion_r3179673501
##########
src/iceberg/table_scan.cc:
##########
@@ -213,17 +215,22 @@ Result<ArrowArrayStream> FileScanTask::ToArrow(
// Generic template implementation for Make
template <typename ScanType>
Result<std::unique_ptr<TableScanBuilder<ScanType>>>
TableScanBuilder<ScanType>::Make(
- std::shared_ptr<TableMetadata> metadata, std::shared_ptr<FileIO> io) {
+ std::shared_ptr<TableMetadata> metadata, std::shared_ptr<FileIO> io,
+ std::shared_ptr<MetricsReporter> reporter, const std::string& table_name) {
ICEBERG_PRECHECK(metadata != nullptr, "Table metadata cannot be null");
ICEBERG_PRECHECK(io != nullptr, "FileIO cannot be null");
- return std::unique_ptr<TableScanBuilder<ScanType>>(
- new TableScanBuilder<ScanType>(std::move(metadata), std::move(io)));
+ return std::unique_ptr<TableScanBuilder<ScanType>>(new
TableScanBuilder<ScanType>(
+ std::move(metadata), std::move(io), std::move(reporter), table_name));
}
template <typename ScanType>
TableScanBuilder<ScanType>::TableScanBuilder(
- std::shared_ptr<TableMetadata> table_metadata, std::shared_ptr<FileIO>
file_io)
- : metadata_(std::move(table_metadata)), io_(std::move(file_io)) {}
+ std::shared_ptr<TableMetadata> table_metadata, std::shared_ptr<FileIO>
file_io,
+ std::shared_ptr<MetricsReporter> reporter, const std::string& table_name)
+ : metadata_(std::move(table_metadata)), io_(std::move(file_io)) {
+ context_.reporter = std::move(reporter);
Review Comment:
should we also check port reporter like table.h above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
