rdblue commented on a change in pull request #1823:
URL: https://github.com/apache/iceberg/pull/1823#discussion_r547528400
##########
File path:
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java
##########
@@ -117,9 +120,39 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
if (exceptionThrown) {
io().deleteFile(newMetadataLocation);
}
+
+ unlock();
+ }
+ }
+
+ private void acquireLock() {
Review comment:
Why does this throw `CommitFailedException` when the lock timeout
expires and on any exception thrown by the lock manager?
That will cause a retry, which will try to acquire the lock again. I don't
think that's the right behavior because failure to get the lock has already
exceeded the lock retry timeout. To wait longer, just extend the lock timeout.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
