rdblue commented on a change in pull request #1823: URL: https://github.com/apache/iceberg/pull/1823#discussion_r547531726
########## File path: aws/src/main/java/org/apache/iceberg/aws/glue/LockManager.java ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.aws.glue; + +/** + * An interface for locking, used to ensure Glue catalog commit isolation. + */ +interface LockManager { + + /** + * Try to acquire lock + * @param lockId a unique id for the lock + * @param expireMillis max duration to hold the lock in milliseconds + * @return if lock acquisition succeeded or not + */ + boolean tryLock(String lockId, long expireMillis); + + /** + * Try to acquire a lock in a given period of time + * @param lockId a unique id for the lock + * @param expireMillis max duration to hold the lock in milliseconds + * @param waitMillis max time to try acquire the lock in milliseconds + * @return if lock acquisition succeeded or not + * @throws InterruptedException if sleep is interrupted between two tries to acquire the lock + */ + default boolean tryLock(String lockId, long expireMillis, long waitMillis) + throws InterruptedException { + long limit = System.currentTimeMillis() + waitMillis; + boolean succeeded = false; + while (!succeeded && System.currentTimeMillis() < limit) { + succeeded = tryLock(lockId, expireMillis); + if (!succeeded) { + Thread.sleep(50); + } + } + return succeeded; Review comment: Can this use `Tasks` instead of custom retry logic? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
