nastra commented on PR #17250: URL: https://github.com/apache/iceberg/pull/17250#issuecomment-4991003299
Thanks for spotting this, but I think we have a few more places that have a similar pattern that we should fix too: Location | Field(s) | Issue -- | -- | -- CreateViewRequestParser | properties | has(PROPERTIES) + getStringMap — writes only when non-empty RemoteSignRequestParser | properties | same pattern RemoteSignRequestParser | body, provider | has() + getString — writes only when non-null PlanTableScanRequestParser | case-sensitive, use-snapshot-schema | has() + getBool — has defaults when absent, but explicit null throws PlanTableScanRequestParser | filter | has(FILTER) + ExpressionParser.fromJson — null throws TableScanResponseParser | delete-files, file-scan-tasks | has() + JsonUtil.get (requires non-null) RESTFileScanTaskParser | delete-file-references, residual-filter | has() + getIntegerList / ExpressionParser.fromJson OAuth2Util | expires_in, scope | has() + getInt / getString on OAuth token responses -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
