C-Loftus commented on PR #1426: URL: https://github.com/apache/iceberg-go/pull/1426#issuecomment-5016502671
Hi @zeroshade thanks for your comment. I agree with the feedback although I think I am currently blocked on us aligning on the proper way to pass the metadata. Would you able to provide any thoughts on this? https://github.com/apache/iceberg-go/pull/1426#issuecomment-4958042729 I think we still need to explicitly align on through approach to pass the projjson metadata. To my understanding Andrei's original comment was to pass the projjson table metadata through a context whereas your follow ups suggested modifying the `VisitGeometry` call directly by adding a new argument. Here is the original alignment question from Andrei: https://github.com/apache/iceberg-go/pull/1426#discussion_r3558214926 I am totally fine with either approach and happy to defer to your preference, I would just like to explicitly align on one option or the other before proceeding and ensure everyone is on the same page. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
