zeroshade commented on code in PR #1426:
URL: https://github.com/apache/iceberg-go/pull/1426#discussion_r3625889630
##########
table/arrow_utils.go:
##########
@@ -528,6 +528,10 @@ func ensureSmallArrowTypes(dt arrow.DataType)
(arrow.DataType, error) {
}
type convertToArrow struct {
+ // the ctx stores table property metadata,
+ // for instance, projjson definitions that can be
+ // used when writing
+ ctx context.Context
Review Comment:
Posted the full decision as a top-level comment:
https://github.com/apache/iceberg-go/pull/1426#issuecomment-5039317736 — short
version: let's resolve `projjson:` via explicit table-properties options rather
than `context.Context` (existing exported funcs stay as thin wrappers), and the
read path needs to recover `projjson:<key>` before this can merge. Widening the
visitor interface is still a no. Thanks for flagging this one to settle first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
