dramaticlly commented on code in PR #17347:
URL: https://github.com/apache/iceberg/pull/17347#discussion_r3643267335
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/SparkWriteOptions.java:
##########
@@ -92,4 +92,8 @@ private SparkWriteOptions() {}
// Controls the buffer size for variant schema inference during writes
public static final String VARIANT_INFERENCE_BUFFER_SIZE =
"variant-inference-buffer-size";
+
+ // Uses the merge append instead of fast append for streaming appends
+ public static final String STREAMING_MERGE_APPEND_ENABLED =
"streaming-merge-append-enabled";
Review Comment:
I don't have strong opinions on this, but it seems now we move all spark
specific control to
https://github.com/apache/iceberg/blob/main/spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/SparkTableProperties.java
instead of
https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/TableProperties.java
in iceberg core.
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/SparkWriteOptions.java:
##########
@@ -92,4 +92,8 @@ private SparkWriteOptions() {}
// Controls the buffer size for variant schema inference during writes
public static final String VARIANT_INFERENCE_BUFFER_SIZE =
"variant-inference-buffer-size";
+
+ // Uses the merge append instead of fast append for streaming appends
+ public static final String STREAMING_MERGE_APPEND_ENABLED =
"streaming-merge-append-enabled";
+ public static final boolean STREAMING_MERGE_APPEND_ENABLED_DEFAULT = false;
Review Comment:
I understand the desire to keep the original behavior, but considering the
`table.newAppend` default to use mergeAppend, also the fact that other
streaming engine integrations like Flink and Kafka Connect today use merge
appends, I would be surprised to see the behavior difference in spark streaming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
