amogh-jahagirdar commented on code in PR #17347:
URL: https://github.com/apache/iceberg/pull/17347#discussion_r3646061111
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/SparkWriteOptions.java:
##########
@@ -92,4 +92,8 @@ private SparkWriteOptions() {}
// Controls the buffer size for variant schema inference during writes
public static final String VARIANT_INFERENCE_BUFFER_SIZE =
"variant-inference-buffer-size";
+
+ // Uses the merge append instead of fast append for streaming appends
+ public static final String STREAMING_MERGE_APPEND_ENABLED =
"streaming-merge-append-enabled";
Review Comment:
I think I'd avoid adding a table property for now. This is largely a job
level configuration and under the condition of a merging writer already have
the table properties for
```
commit.manifest.min-count-to-merge
commit.manifest-merge.enabled
```
Meaning in a future version if we're able to change the default to do a
merging append I think we'd have all the configurations required in order to
express things at a table property level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
