rdblue commented on code in PR #17322:
URL: https://github.com/apache/iceberg/pull/17322#discussion_r3647904610
##########
core/src/test/java/org/apache/iceberg/TestTrackedFileAdapters.java:
##########
@@ -351,6 +344,25 @@ void testNullContentStatsReturnsNullStats() {
assertThat(dataFile.upperBounds()).isNull();
}
+ @Test
+ void testMetricTrackedByNoColumnReturnsNull() {
Review Comment:
I don't think additional tests are needed here. Behavior of the new maps is
thoroughly checked by `TestContentStatsBackedMap`, which is a better place for
the tests. The existing tests demonstrate that content stats are adapted to the
maps, but the behavior does not need to be thoroughly validated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
