dramaticlly commented on code in PR #17322:
URL: https://github.com/apache/iceberg/pull/17322#discussion_r3661053867
##########
core/src/main/java/org/apache/iceberg/StatsUtil.java:
##########
@@ -249,12 +252,12 @@ private static Types.StructType geoUpperBound(int baseId)
{
private static Types.NestedField lowerBoundField(Type type, int baseId) {
Type boundType = isGeoType(type) ? geoLowerBound(baseId) : type;
- return optional(baseId + LOWER_BOUND_OFFSET, "lower_bound", boundType);
Review Comment:
Not direct relate to your change, but I think `geoLowerBound(baseId)`
actually returns StructType, but the `Conversions.toByteBuffer` called within
ContentStatsBackedMap.bound() today might not handle the struct type for
geometry properly.
https://github.com/apache/iceberg/blob/c8a4b980627c5580c0550e99920649d6b6bcebc9/api/src/main/java/org/apache/iceberg/types/Conversions.java#L95-L145.
I am not sure the status of upper/lower bound of geometry/geography type in
main, but it seems we can run into `UnsupportedOperationException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
