fallintoplace opened a new pull request, #845: URL: https://github.com/apache/iceberg-cpp/pull/845
Arrow schema conversion currently ignores `std::from_chars` failures when reading `PARQUET:field_id`. A value such as `1x` is silently accepted as field ID `1`, while an overflow or empty value becomes the unknown-field sentinel. This can turn corrupt metadata into a misleading Iceberg schema. Return an invalid-schema error unless the complete field ID value parses as an `int32_t`. Missing field-ID metadata remains supported and continues to use the unknown-field sentinel. Regression coverage includes trailing characters, overflow, and an empty value. Tested with: - `arrow_test --gtest_filter=FromArrowSchemaTest.RejectMalformedFieldIdMetadata` - full CTest suite (17 test binaries) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
