evindj commented on code in PR #845:
URL: https://github.com/apache/iceberg-cpp/pull/845#discussion_r3651122218
##########
src/iceberg/schema_internal.cc:
##########
@@ -227,7 +227,7 @@ Status ToArrowSchema(const Schema& schema, ArrowSchema*
out) {
namespace {
-int32_t GetFieldId(const ArrowSchema& schema) {
+Result<int32_t> GetFieldId(const ArrowSchema& schema) {
if (schema.metadata == nullptr) {
return kUnknownFieldId;
Review Comment:
Should this be changed? It is not clear to me what is the difference between
unknowFieldId (returning the constant) and InvalidFieldId (returning in a error)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
