fallintoplace opened a new pull request, #846: URL: https://github.com/apache/iceberg-cpp/pull/846
When writing new table metadata, C++ extracts the version segment from the current metadata filename with `std::from_chars`. The parse result is currently ignored, so a filename such as `00010x-...metadata.json` is treated as version 10 and the next file is written as version 11. The Java implementation treats any malformed or out-of-range version segment as unparseable and starts the generated filename at version 0. Match that behavior by requiring `from_chars` to consume the complete segment successfully. Regression coverage includes trailing characters, overflow, and an empty segment through the public metadata write path. Tested with: - `arrow_test --gtest_filter=MetadataIOTest.WriteMetadataWithBase` - full CTest suite (17 test binaries) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
