fallintoplace opened a new pull request, #847: URL: https://github.com/apache/iceberg-cpp/pull/847
Boolean table and catalog properties are parsed through `ConfigBase`. The current conversion only recognizes the exact lowercase string `true`, so values such as `TRUE` and `TrUe` silently become `false`. Java uses `Boolean.parseBoolean`, which recognizes `true` case-insensitively. Match that behavior with the existing case-insensitive string helper. Values other than a case-insensitive `true` continue to resolve to `false`, preserving Java semantics. Regression coverage includes lowercase, uppercase, and mixed-case true values, along with false and unrecognized values. Tested with: - `util_test --gtest_filter=ConfigTest.ParseBooleanIgnoringCase` - pre-commit hooks for the changed files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
