JosephLenton commented on PR #2916: URL: https://github.com/apache/iceberg-rust/pull/2916#issuecomment-5095916161
A few notes ... Avro has an `avro::Value::Uuid` type so I did look into adding a `RawLiteralEnum::Uuid` type. Then the types internally could all match up. However this doesn't play well with Serde + `apache_avro::to_value`. `Uuid` will only serialise to bytes or a string. The other thing I found is with the integration tests. I found when I had multiple tests in the same file it would fail with a Reqwest + Tokio error. I believe in `opendal-core` there is a global Reqwest client, and this will keep sessions alive across multiple tests within the same program (i.e. a single integration test). It doesn't do this if the endpoint changes (this is relevant later). As a workaround I put my second test into a second file. I'd be happy to try to solve this in a followup ticket if there is interest, and any other work to make test simpler. The solution is technically straight forward, but would be a chunk of code. We are talking a custom S3 storage layer, changing OpenDal core, or moving to use `test-containers` (as the endpoint will be different across tests). So I've left that out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
