JosephLenton commented on PR #2916:
URL: https://github.com/apache/iceberg-rust/pull/2916#issuecomment-5116926605

   Hey @blackmwk those changes are done. Please take another look when you have 
time!
   
   Btw I found about 4 items which I suspect to be bugs whilst working on this. 
I can add them as tickets later when I have time:
   
    * I think UUID fields are missing the metadata 
`ARROW:extension:metadata=arrow.uuid`, such as here on my PR: 
https://github.com/apache/iceberg-rust/pull/2916/changes#diff-78166ca072bfb69d2fbd40e6e7c1bbf337c85e52f14abd742efa6a03f898d8c0R1013
    * You cannot insert a UUID as a string. i.e. `INSERT ... VALUES 
('aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee')` fails. You must use a hex literal 
instead.
    * I managed to get the error `called `Result::unwrap()` on an `Err` value: 
Execution("type mismatch and can't cast to got Utf8 and FixedSizeBinary(16)")`, 
and this has a typo in it (the `cast to got ...` part).
    * When inserting data into a partitioned table, if the source data is a 
select statement without a from, then insertion panics. i.e. `INSERT INTO 
my_table SELECT 123, 456;` fails if the table has a partition.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to