massdosage commented on a change in pull request #1979:
URL: https://github.com/apache/iceberg/pull/1979#discussion_r551425911
##########
File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java
##########
@@ -80,6 +82,7 @@
private final String warehouseLocation;
private final FileSystem fs;
private final FileIO fileIO;
+ private boolean suppressACLExcpetion = false;
Review comment:
```suggestion
private boolean suppressACLException = false;
```
##########
File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java
##########
@@ -139,6 +142,37 @@ public String name() {
return catalogName;
}
+ private boolean isTableDir(Path path) {
+ Path metadataPath = new Path(path, "metadata");
+ // Only the path which contains metadata is the path for table, otherwise
it could be
+ // still a namespace.
+ try {
+ return fs.listStatus(metadataPath, TABLE_FILTER).length >= 1;
+ } catch (FileNotFoundException e) {
+ return false;
+ } catch (IOException e) {
+ if (suppressACLExcpetion) {
Review comment:
These exceptions could be thrown be errors that don't have anything to
do with ACL so can we try come up with a more generic name for this flag?
`suppressIOException` maybe? I guess it depends on where they will be
configured and how.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
