cccs-jc commented on pull request #1979:
URL: https://github.com/apache/iceberg/pull/1979#issuecomment-754869962
sure I could check if it's an azure blob storage exception but that would
make it specific to azure..
This is the outline of the listTables method. In the end if a location can't
be read it will return NoSuchNamespaceException. If for any reason you cannot
list the dir/metadata folder it won't return the table.
So the fact that IOException are not return will not break anything. Worst
case users don't see the namespace/tables and hunt down why that is. Maybe
logging the error would be helpful while still returning false. My goal here is
to not interrupt the execution of listTables if certain user's can't access
certain tables. So having a log entry might be useful for the admins/operators.
tables listTables(location)
if !isDirectory(location) (tries to list "location", if any exception
return false)
throw NoSuchNamespaceException
for dir in location
if dir.isFolder()
if isTableDir(dir) (tries to list "dir/metadata", if any
exception return false)
add to list of tables to return
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
