nastra commented on code in PR #17391:
URL: https://github.com/apache/iceberg/pull/17391#discussion_r3680985031
##########
core/src/test/java/org/apache/iceberg/TestFileGenerationUtil.java:
##########
@@ -101,12 +115,35 @@ void testBoundsForAllMetricsModes(String metricsMode) {
ImmutableMap.of() /* no lower bounds */,
ImmutableMap.of() /* no upper bounds */);
- checkBounds(metrics, metricsConfig);
+ checkBounds(SCHEMA, metrics, metricsConfig);
+ }
+
+ @ParameterizedTest
+ @ValueSource(strings = {"none", "counts", "truncate(16)", "full"})
+ public void testBoundsForNestedTypes(String metricsMode) {
+ MetricsConfig metricsConfig =
+ MetricsConfig.from(
+ ImmutableMap.of(TableProperties.DEFAULT_WRITE_METRICS_MODE,
metricsMode), SCHEMA, null);
Review Comment:
should this be using NESTED_SCHEMA?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
